Skip to content

Remove old code #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
noemifrisina merged 8 commits into from
May 20, 2025
Merged

Remove old code #345

noemifrisina merged 8 commits into from
May 20, 2025

Conversation

@noemifrisina
Copy link
Collaborator

@noemifrisina noemifrisina commented May 20, 2025 •
edited
Loading

  • Removed obsolete serial_images_nexus, multi_images_nexus is used in all cases for tristan

@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 41.67%. Comparing base (0e3eecb) to head (38f8f4b).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/nexgen/nxs_copy/copy_tristan_nexus.py 0.00% 2 Missing ⚠️
src/nexgen/beamlines/I19_2_nxs.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
+ Coverage   40.65%   41.67%   +1.01%     
==========================================
  Files          49       48       -1     
  Lines        4287     4514     +227     
  Branches      592      617      +25     
==========================================
+ Hits         1743     1881     +138     
- Misses       2432     2512      +80     
- Partials      112      121       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-advanced-security[bot]
github-advanced-security bot found potential problems May 20, 2025
View reviewed changes
docs/conf.py
# Explicitely import modules that have a pydantic model inheriting from another one.
# Workaround to make autodoc_pydantic happy as it won't otherwise be able to import it.
from nexgen.beamlines import I19_2_gda_nxs, I19_2_nxs, SSX_Eiger_nxs, SSX_Tristan_nxs # noqa
from nexgen.beamlines import I19_2_gda_nxs, I19_2_nxs, SSX_Eiger_nxs # noqa

Check notice

Code scanning / CodeQL

Unused import Note documentation

Import of 'I19_2_gda_nxs' is not used.
Import of 'I19_2_nxs' is not used.
Import of 'SSX_Eiger_nxs' is not used.

Copilot Autofix

AI 8 months ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

@noemifrisina noemifrisina merged commit 023d882 into main May 20, 2025
12 checks passed
@noemifrisina noemifrisina deleted the remove-old-ssx-code-and-update-docs branch May 20, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@noemifrisina