Skip to content

[LIMS-2133] Use magnification value from database#21

Merged
gfrn merged 2 commits intomasterfrom
fix/lims-2133/session-report
Mar 12, 2026
Merged

[LIMS-2133] Use magnification value from database#21
gfrn merged 2 commits intomasterfrom
fix/lims-2133/session-report

Conversation

@gfrn
Copy link
Copy Markdown
Collaborator

@gfrn gfrn commented Mar 6, 2026

JIRA ticket: LIMS-2133

Summary:

Previously, magnification values in the PDF report were hardcoded, as they weren't available in the database. Now they are, so we must use that instead

Changes:

  • Use magnification value from database in PDF report

To test:

@gfrn gfrn requested review from MattPrit and ndg63276 March 6, 2026 13:28
@gfrn gfrn self-assigned this Mar 6, 2026
@gfrn gfrn added the bug Something isn't working label Mar 6, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.80%. Comparing base (c9102e3) to head (dcaabaa).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   94.80%   94.80%           
=======================================
  Files          46       46           
  Lines        1887     1887           
=======================================
  Hits         1789     1789           
  Misses         98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@MattPrit MattPrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfrn gfrn merged commit 0905a83 into master Mar 12, 2026
12 checks passed
@gfrn gfrn deleted the fix/lims-2133/session-report branch March 12, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants