Skip to content

[LIMS-2099] Return cassette position for data collection group#23

Merged
gfrn merged 1 commit intomasterfrom
improvement/lims-2099/return-cassette-slot
Mar 20, 2026
Merged

[LIMS-2099] Return cassette position for data collection group#23
gfrn merged 1 commit intomasterfrom
improvement/lims-2099/return-cassette-slot

Conversation

@gfrn
Copy link
Copy Markdown
Collaborator

@gfrn gfrn commented Mar 9, 2026

JIRA ticket: LIMS-2099

Summary:

Since more data is being inserted into SCAUP, more DCGs have cassette positions associated with them. Since the comments column is not being used all that often, it would be useful to replace it with the cassette position

Changes:

  • Return cassette position for data collection group

To test:

Assuming you have ispyb-restore mounted:

@gfrn gfrn requested review from MattPrit and ndg63276 March 9, 2026 15:58
@gfrn gfrn self-assigned this Mar 9, 2026
@gfrn gfrn added the enhancement New feature or request label Mar 9, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.80%. Comparing base (c9102e3) to head (f4dd525).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   94.80%   94.80%           
=======================================
  Files          46       46           
  Lines        1887     1888    +1     
=======================================
+ Hits         1789     1790    +1     
  Misses         98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@stephen-riggs stephen-riggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, all looks good to me

@gfrn gfrn merged commit a43966a into master Mar 20, 2026
14 checks passed
@gfrn gfrn deleted the improvement/lims-2099/return-cassette-slot branch April 13, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants