Fix motor off updating cs#123
Merged
Merged
Conversation
Add back the changes made in the commit 30dc0a2
Fix the SegFault that occurs when a motor is assigned into a CS not declared in builder
|
Looks good to me - thanks |
Contributor
|
Hi @LeandroMartinsdS and @JamesOHeaDLS I didn't notice this problem during the development of version R2-6-1, how was it discovered? Do you have an estimated date for the new merge? Thanks! |
Contributor
Author
|
Sorry for the long silence. That issue was observed when we have added a new motor into a a controller, where this motor was addressed to a coordinate system in the controller's project with no need, and therefore wasn't declared in the IOC builder. The segmentation fault didn't happen using pmac driver previous releases . I will merge this feature and tag it as 2-6-4b1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request patches the feature of updating the CS axis VAL when the OFF of any motor belonging to the CS changes.
The feature was introduced in R2-6-1, and after removed in R2-6-2 due to a Segmentation Fault occurring when a motor is allocated to a CS not declared in the builder.