Fix buffer overlap#145
Merged
Merged
Conversation
- CS Feedrate setting - Manual group - Deferred command
Contributor
Author
|
Added @shihab-dls for sharing knowledge of what's happening in pmac |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge addresses a bug caused by buffer overlap in
sprintfcalls where the destination buffer was also used as a source (e.g., sprintf(command, "%s ...", command)). This led to string corruption during trajectory building for the PowerPMAC, when compiler optimisations were enabled.The issue appeared when running from the ioc-pmac, due to the compiler being in later version compared to dev-container
Fix:
sprintfusage withsnprintfandstrncatto ensure safe string concatenation.Impact: