Enable mypy checking for dlstbx #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anthchirp
commented
Dec 13, 2021
Comment on lines
+28
to
+36
| centre_x: Optional[int] = None | ||
| centre_y: Optional[int] = None | ||
| centre_x_box: Optional[int] = None | ||
| centre_y_box: Optional[int] = None | ||
| status: str = "fail" | ||
| message: str = "fail" | ||
| best_image: int = None | ||
| reflections_in_best_image: int = None | ||
| best_region: List[Tuple[int, int]] = None | ||
| best_image: Optional[int] = None | ||
| reflections_in_best_image: Optional[int] = None | ||
| best_region: Optional[List[Tuple[int, int]]] = None |
Contributor
Author
There was a problem hiding this comment.
While adding Optional is the minimally invasive and technically correct solution it may not be appropriate. One for RG to decide?
added 5 commits
December 15, 2021 16:21
|
I've fixed the alphafold wrapper/trigger service issues. Mimas issues should be addressed in #131. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables a mypy precommit for dlstbx, and fixes a bunch of outstanding type issues.
The following remain:
Some of them are stuff I don't want to look into (pydantic), others (mimas/trigger.py) are real type inconsistencies where stuff is defined as
Optionalbut then code assumes it will never seeNone.