Verify HDF5 files are 1.10 version#25
Merged
Merged
Conversation
graeme-winter
commented
Mar 2, 2021
Contributor
Author
graeme-winter
left a comment
graeme-winter
left a comment
There was a problem hiding this comment.
I have added some annotation to my own change set as I don't always know the best way to do things -> asking for input
rjgildea
reviewed
Mar 2, 2021
Co-authored-by: Richard Gildea <rjgildea@users.noreply.github.com>
graeme-winter
commented
Mar 2, 2021
report errors on invalid files separately from 1.8 formatted files
Anthchirp
force-pushed
the
verify-hdf5-110
branch
from
5872ca1 to
33b9ce3
Compare
Anthchirp
approved these changes
Mar 3, 2021
Contributor
Anthchirp
left a comment
Anthchirp
left a comment
There was a problem hiding this comment.
This can be merged I belive?
Contributor
|
Leave for now, merge for shutdown |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.diamond.ac.uk/browse/SCI-9671
Verify that the files given are in HDF5 1.10 format but not compatible with 1.8 which would indicate that they are written with SWMR compatibility.