Merged
Conversation
rtuck99
requested review from
graeme-winter and
ndevenish
and removed request for
graeme-winter and
ndevenish
This was referenced Dec 16, 2024
…our in the implementation
This is required, but most of the time this is used it's installed on top of a dials that hasn't been installed through conda, so adding this here would probably try to install dials via conda on top of dials
rtuck99
force-pushed
the
mx-bluesky_221_document_the_gridscan
branch
from
0e7701f to
dbd6b2b
Compare
isikhar
reviewed
Mar 26, 2025
| ), | ||
| [dlstbx.util.xray_centering_3d.GridScan3DResult( | ||
| centre_of_mass=(2.5, 1.5, 0.5), | ||
| max_voxel=(2.5, 1.5, 0.5), |
Contributor
There was a problem hiding this comment.
This test fails raising pydantic error as max_voxel parameter is declared in GridScan3DResult class as max_voxel: Tuple[int, ...].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitted as part of DiamondLightSource/mx-bluesky#221
This PR adds some comments and test code to better document the output of the gridscans. However there are a few points to mention/things I'd appreciate some feedback on:
requirements.conda.txtin order to get the unit tests to run. They still don't all pass but at least they run. Sort of.setup.cfgbut the tests don't compile unless you have at least 3.10