Conversation
Handles case where no peaks are found. Creates data class for storing peak data in and moves unnecessary logic from ispyb function.
Use of pipeline final set by the recipe "pipeline_final" job parameter. Primary results files to copy to pipeline_final and to upload to ISPyB set in the recipe too, via the "primary_result_files" job parameter. Logic set up to optionally use the pipeline_final if it is defined. Rendered images will be copied to piepline final but will not be uploaded as an attachment. They get uploaded to the MXMRRunBlob table instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the following fixes and improvements to the metal_id pipeline: