Added compatibility for pip >v22.2.2 #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tieneupin
added
bug
Contributor
Author
|
Additionally, locked |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Author
|
Resolved CodeSQL warning about polynomial regular expression. Unable to resolve warnings related to server-side request forgery. |
…ific; updated URL validation logic again
Contributor
Author
|
Successfully made contact with GitHub's CodeQL team. Will dismiss alert if unable to resolve issue by end of week. Current state of changes made:
|
11 tasks
|
|
||
| # Get HTTP response | ||
| url = f"https://pypi.org/simple/{package_clean}" | ||
| response = requests.get(url) |
Check failure
Code scanning / CodeQL
Partial server-side request forgery
d-j-hatton
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #268.
As of
pip v22.3(in accordance with PEP 658),pipnow expects an additionalwhl.metadatafile to be served from the Simple Index it is using for the package installation. This file is not visible on the Simple Index web page, but is expected to be accessible by replacing.whlwith.whl.metadatain the URL.The bootstrap script previously only copied across what was explicitly visible on the PyPI Simple Index, so these implied URLs were not ported across as well. This commit fixes that by explicitly creating and displaying links to the
whl.metadataon the proxy server as well.Python versions tested: