Skip to content

More CLEM fixes #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tieneupin merged 14 commits into from
Jun 19, 2024
Merged

More CLEM fixes #306

tieneupin merged 14 commits into from
Jun 19, 2024

Conversation

@tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Jun 13, 2024 •
edited
Loading

Pull request to resolve some of the issues mentioned in issue #304.

  • More robust sorting of TIFF files once the stack exceeds 100 images
  • Better logic to distinguish between image series that start with same position number
  • Skipped processing of binned "Position X_pmd_X--" TIFF files
  • Skipped processing of "Postion X_histo" XLIF files
  • Optimised rsync parser logic to read rsync output correctly
  • Corrected incorrect variable in tiff_to_stack function being passed to zocalo cluster

@tieneupin tieneupin added server Relates to the server component client Relates to the client component cryo-clem Part of the cryo-CLEM pipeline extension labels Jun 13, 2024
@tieneupin tieneupin self-assigned this Jun 13, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 13, 2024
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 13, 2024
View reviewed changes
@tieneupin tieneupin requested a review from d-j-hatton June 17, 2024 11:37
@tieneupin tieneupin marked this pull request as ready for review June 17, 2024 11:38
d-j-hatton
d-j-hatton reviewed Jun 18, 2024
View reviewed changes
@tieneupin @d-j-hatton
Removed commented out function
c893312 
Co-authored-by: Daniel Hatton <daniel.hatton@diamond.ac.uk>
d-j-hatton
d-j-hatton approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@d-j-hatton d-j-hatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@tieneupin tieneupin merged commit cb35f7d into main Jun 19, 2024
@tieneupin tieneupin deleted the clem-fixes branch June 19, 2024 08:50
@tieneupin tieneupin mentioned this pull request Jun 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d-j-hatton d-j-hatton d-j-hatton approved these changes

Assignees

@tieneupin tieneupin

Labels

client Relates to the client component cryo-clem Part of the cryo-CLEM pipeline extension server Relates to the server component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tieneupin @d-j-hatton