Remove calls to get tilt series and tag #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
==========================================
- Coverage 28.67% 28.62% -0.05%
==========================================
Files 71 71
Lines 9604 9561 -43
Branches 1291 1284 -7
==========================================
- Hits 2754 2737 -17
+ Misses 6751 6725 -26
Partials 99 99 |
d-j-hatton
approved these changes
Oct 18, 2024
Contributor
d-j-hatton
left a comment
d-j-hatton
left a comment
There was a problem hiding this comment.
If the linters didn't pick up any stray references to the removed attributes then seems fine, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the functions to extract the tilt series and tag from tomography files, and instead uses the existing
_construct_tilt_series_namemethod.All the tests passed, but it's likely this removes back-compatibility with older tomo versions and SerialEM.
Also changes the angle index determination to be match the function in
cryoem-services