Skip to content

Conversation

@stephen-riggs
Copy link
Contributor

There is a condition we have hit on the flush where movies cannot be inserted as the foil hole is not inserted.

This will hopefully ensure that flushed movies only have a foil hole if it is present in the murfey database.

@codecov
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 26.82%. Comparing base (153719e) to head (b45ec53).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
- Coverage   27.06%   26.82%   -0.25%     
==========================================
  Files          78       78              
  Lines       10293    10486     +193     
  Branches     1361     1417      +56     
==========================================
+ Hits         2786     2813      +27     
- Misses       7419     7573     +154     
- Partials       88      100      +12     

@d-j-hatton
Copy link
Contributor

Do you know why this is happening? Seems like a case we just never want to happen

@stephen-riggs
Copy link
Contributor Author

I think the third commit on here is probably the answer: it's trying to use the foil hole EPU id, not the murfey db id.
But I'm not sure, so I've tried to catch every case here

@stephen-riggs stephen-riggs merged commit 7c2a7d9 into main Jan 28, 2025
17 checks passed
@stephen-riggs stephen-riggs deleted the flush-ensure-foil-hole branch January 28, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants