Skip to content

Conversation

@stephen-riggs
Copy link
Contributor

No description provided.

@stephen-riggs stephen-riggs requested a review from d-j-hatton March 7, 2025 09:05
@codecov
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 28.62%. Comparing base (625ca1f) to head (2aa3ba7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #504   +/-   ##
=======================================
  Coverage   28.62%   28.62%           
=======================================
  Files          78       78           
  Lines       10219    10222    +3     
  Branches     1354     1355    +1     
=======================================
+ Hits         2925     2926    +1     
- Misses       7194     7195    +1     
- Partials      100      101    +1     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

)
self._tilt_series_with_pjids.append(tilt_series)
else:
logger.info(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this message need to pop up on the TUI/server log (levels info and above will appear, based on Murfey's current settings)? It won't appear if we switch this to logger.debug()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably worth recording this to the TUI, as it shows that processing hasn't started yet

Copy link
Contributor

@tieneupin tieneupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@stephen-riggs stephen-riggs merged commit aa51135 into main Mar 11, 2025
17 checks passed
@stephen-riggs stephen-riggs deleted the tomo-save-dcs branch March 11, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants