Skip to content

Conversation

@tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Apr 8, 2025

Fully resolves issue #446 by migrating the client-side utility functions into a separate module named murfey.util.client, thereby preventing unwanted import chains. Also adds unit tests for the migrated read_config() and _get_visit_list() functions.

Additionally, added some logic into read_config() to allow us to specify config files directly using MURFEY_CLIENT_CONFIGURATION (same naming pattern as MURFEY_MACHINE_CONFIGURATION and MURFEY_SECURITY_CONFIGURATION) so that the file name doesn't have to default to .murfey.

Verification Checks

  • Server-side commands such as murfey.create_db and murfey.add_user no longer throw the "Client config not found" warning
  • TUI workflows run
    • SPA
    • Tomo
    • CLEM
  • Web UI workflows run
    • SPA
    • Tomo
    • CLEM

@tieneupin tieneupin linked an issue Apr 8, 2025 that may be closed by this pull request
@tieneupin tieneupin added dependencies client Relates to the client component labels Apr 8, 2025
@tieneupin tieneupin self-assigned this Apr 8, 2025
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 67.07317% with 54 lines in your changes missing coverage. Please review.

Project coverage is 30.24%. Comparing base (e150506) to head (a59248e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
+ Coverage   30.20%   30.24%   +0.04%     
==========================================
  Files          79       80       +1     
  Lines       10500    10496       -4     
  Branches     1401     1401              
==========================================
+ Hits         3171     3174       +3     
+ Misses       7223     7217       -6     
+ Partials      106      105       -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…TION' file first before defaulting to looking for 'MURFEY_CLIENT_CONFIG_HOME' and then the default home
@tieneupin tieneupin requested review from d-j-hatton and stephen-riggs and removed request for d-j-hatton April 10, 2025 17:32
@tieneupin tieneupin marked this pull request as ready for review April 10, 2025 17:35
@tieneupin tieneupin merged commit 8bd267a into main Apr 11, 2025
17 checks passed
@tieneupin tieneupin deleted the migrate-client-config branch April 11, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Relates to the client component dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Client-side dependencies now also needed on server side

3 participants