-
Notifications
You must be signed in to change notification settings - Fork 1
Migrate client-side utility functions to a separate module #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 'read_config' and requests-modifying function from 'client.__init__'
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
==========================================
+ Coverage 30.20% 30.24% +0.04%
==========================================
Files 79 80 +1
Lines 10500 10496 -4
Branches 1401 1401
==========================================
+ Hits 3171 3174 +3
+ Misses 7223 7217 -6
+ Partials 106 105 -1 🚀 New features to boost your workflow:
|
…TION' file first before defaulting to looking for 'MURFEY_CLIENT_CONFIG_HOME' and then the default home
… server if it is behind a proxy
…o example visits need to be converted too
stephen-riggs
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully resolves issue #446 by migrating the client-side utility functions into a separate module named
murfey.util.client, thereby preventing unwanted import chains. Also adds unit tests for the migratedread_config()and_get_visit_list()functions.Additionally, added some logic into
read_config()to allow us to specify config files directly usingMURFEY_CLIENT_CONFIGURATION(same naming pattern asMURFEY_MACHINE_CONFIGURATIONandMURFEY_SECURITY_CONFIGURATION) so that the file name doesn't have to default to.murfey.Verification Checks
murfey.create_dbandmurfey.add_userno longer throw the "Client config not found" warning