Skip to content

Conversation

@stephen-riggs
Copy link
Contributor

We shouldn't need this any more

@codecov
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.30%. Comparing base (7cffb19) to head (4b1ca0e).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
- Coverage   28.75%   28.30%   -0.46%     
==========================================
  Files          80       79       -1     
  Lines       10619    10474     -145     
  Branches     1416     1398      -18     
==========================================
- Hits         3054     2965      -89     
+ Misses       7463     7408      -55     
+ Partials      102      101       -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin
Copy link
Contributor

The deletions looks fine, but I think I'll need more of a history lesson to understand what it's been replaced with in Murfey. If it's not too urgent, I can also checkout this branch, build it, and check that both the TUI and Web UI still work.

@tieneupin
Copy link
Contributor

Will test this after testing PR #563 .

@tieneupin
Copy link
Contributor

tieneupin commented Apr 11, 2025

Verification Checks

  • Web UI
    • Tomography
    • SPA
  • TUI
    • Tomography
    • SPA

@stephen-riggs stephen-riggs merged commit e150506 into main Apr 11, 2025
17 checks passed
@stephen-riggs stephen-riggs deleted the no-global-state branch April 11, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants