-
Notifications
You must be signed in to change notification settings - Fork 1
Websocket fix #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Websocket fix #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ribe purpose of code blocks
…ks; added regular pinging when executing 'WebSocketApp.run_forever()'
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
==========================================
- Coverage 30.19% 30.18% -0.02%
==========================================
Files 80 80
Lines 10567 10574 +7
Branches 1410 1410
==========================================
+ Hits 3191 3192 +1
- Misses 7270 7276 +6
Partials 106 106 🚀 New features to boost your workflow:
|
d-j-hatton
reviewed
May 20, 2025
d-j-hatton
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the websocket connection would be prone to breaking, preventing logs from the client from being displayed in the loggers set up on the server side. This problem got even more pronounced as the Murfey ecosystem became more complicated, especially with the addition of a React app frontend and having NGINX manage incoming connections.
This PR seems to have resolved this issue (confirmed after multiple runs of the data transfer workflow with both the instrument server and TUI modes of transfer happening simultaneously) by encasing the
WebSocketApp.send()andWebSocketApp.close()commands in a try-except block. Additionally, theping_intervalparameter was added to theWebSocketApp.run_forever()function to prevent the connection from closing when the client is idling.Also tidies up and adds comments to describe the code in
murfey.client.__init__.