Skip to content

Conversation

@tieneupin
Copy link
Contributor

After implementing proper authentication between the backend, the client, and the web frontend, the TUI's previous authentication method was not considered, leading to it failing authentication when connecting to the backend server after the recent update.

This PR fixes that by adding an additional elif ... block that takes the TUI's token into account and authorises that. In the longer term, having the TUI use the same authentication method as the instrument server would be ideal, but this is a lower priority.

@tieneupin tieneupin requested a review from d-j-hatton June 10, 2025 08:48
@codecov
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 31.85%. Comparing base (2a4bf84) to head (92acd0c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #604      +/-   ##
==========================================
- Coverage   31.86%   31.85%   -0.02%     
==========================================
  Files          91       91              
  Lines       10737    10747      +10     
  Branches     1425     1429       +4     
==========================================
+ Hits         3421     3423       +2     
- Misses       7203     7211       +8     
  Partials      113      113              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-j-hatton
Copy link
Contributor

I was thinking maybe we should have a config option to turn this behaviour off so we can make some systems more secure

…ing the simpler 'user' token; allows this looser verification to be switched on or off per instrument
@tieneupin
Copy link
Contributor Author

I was thinking maybe we should have a config option to turn this behaviour off so we can make some systems more secure

Added a key to the security config to optionally allow verification using the less secure 'user' token.

@tieneupin tieneupin merged commit 041056e into main Jun 10, 2025
17 checks passed
@tieneupin tieneupin deleted the tui-fix branch June 10, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants