-
Notifications
You must be signed in to change notification settings - Fork 1
Match data collection groups for atlases and processing #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stephen-riggs
wants to merge
36
commits into
main
Choose a base branch
from
match-atlas-dcgs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
==========================================
+ Coverage 38.51% 39.32% +0.81%
==========================================
Files 99 100 +1
Lines 11663 11717 +54
Branches 1542 1556 +14
==========================================
+ Hits 4492 4608 +116
+ Misses 6973 6894 -79
- Partials 198 215 +17 🚀 New features to boost your workflow:
|
tieneupin
approved these changes
Nov 28, 2025
Contributor
tieneupin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work. I couldn't spot anything glaringly wrong, and the pipeline works in our test setup.
ba3f1df to
43450f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to merge with #695
Creates a common function for data collection group creation by the client. The data collection groups are made as atlases then updated to be SPA or Tomo if data collection happens.
Diff looks bigger than it really is as a test file got moved.