Skip to content

SmartEM integration for the EPU context#772

Merged
d-j-hatton merged 13 commits intomainfrom
epu-smartem-integration
Apr 1, 2026
Merged

SmartEM integration for the EPU context#772
d-j-hatton merged 13 commits intomainfrom
epu-smartem-integration

Conversation

@d-j-hatton
Copy link
Copy Markdown
Contributor

  • Add a smartem grid when a data collection group is made
  • Add smartem gridsquares alongside Murfey squares, and the same for foilholes
  • Once all squares have been added register the grid in smartem to trigger quality predictions
  • Similar for foilholes on each square
  • Add some post processing stage hooks to pass the correct measurement information to smartem

Not fully tested for robustness against different metadata file sequences but designed to not interfere with current capabilities

bit of a stopgap, hopefully come up with better integration at a later date
… to the data collection group registration where a smartem grid will also be registered

this commit is just the client side
… makes a smartem micrograph, ignoring metadata for now)

paths for grid and atlas may need sorting out
at the moment this does the publish directly, possibly need to move that to some kind of API call later to keep the interface surface small
…tion to trigger quality predictions, and add smartem gridsquare registration after foil holes have been registered on a square
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 24.59893% with 141 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.81%. Comparing base (7df6b28) to head (36e4b49).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #772      +/-   ##
==========================================
- Coverage   49.29%   48.81%   -0.49%     
==========================================
  Files          92       94       +2     
  Lines        9818    10503     +685     
  Branches     1296     1480     +184     
==========================================
+ Hits         4840     5127     +287     
- Misses       4728     5082     +354     
- Partials      250      294      +44     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@stephen-riggs stephen-riggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this works but it looks safe and won't break existing features

@d-j-hatton d-j-hatton merged commit 16fd649 into main Apr 1, 2026
17 checks passed
@d-j-hatton d-j-hatton deleted the epu-smartem-integration branch April 1, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants