Skip to content

add and set alert_end_time#806

Merged
Abigail-Yates merged 1 commit into
mainfrom
alert-end-time
May 22, 2026
Merged

add and set alert_end_time#806
Abigail-Yates merged 1 commit into
mainfrom
alert-end-time

Conversation

@Abigail-Yates
Copy link
Copy Markdown
Collaborator

  • Add alert_end_time as a prometheus metric. It will be a unix timestamp.
  • Set alert_end_time when session is created (if one exists and is further in the future than the current alert_end_time)
  • Update alert_end_time when session end time is updated

(also updated one log warning statement in the create silence endpoint to make it consistent with the others)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

❌ Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.08%. Comparing base (408efc8) to head (69cdc18).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
- Coverage   52.12%   52.08%   -0.05%     
==========================================
  Files          96       96              
  Lines       10402    10414      +12     
  Branches     1377     1381       +4     
==========================================
+ Hits         5422     5424       +2     
- Misses       4696     4706      +10     
  Partials      284      284              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/murfey/server/api/instrument.py
Copy link
Copy Markdown
Contributor

@stephen-riggs stephen-riggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me

@Abigail-Yates Abigail-Yates merged commit d62487f into main May 22, 2026
17 checks passed
@Abigail-Yates Abigail-Yates deleted the alert-end-time branch May 22, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants