Convert xrm images to tiffs#837
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #837 +/- ##
==========================================
+ Coverage 53.10% 53.23% +0.12%
==========================================
Files 100 101 +1
Lines 10855 11106 +251
Branches 1439 1489 +50
==========================================
+ Hits 5765 5912 +147
- Misses 4783 4873 +90
- Partials 307 321 +14 🚀 New features to boost your workflow:
|
tieneupin
reviewed
Jul 3, 2026
tieneupin
reviewed
Jul 3, 2026
tieneupin
reviewed
Jul 3, 2026
tieneupin
approved these changes
Jul 3, 2026
tieneupin
left a comment
Contributor
There was a problem hiding this comment.
Some comments and suggestions, but the code looks good otherwise!
tieneupin
reviewed
Jul 3, 2026
stephen-riggs
added a commit
to DiamondLightSource/cryoem-services
that referenced
this pull request
Jul 3, 2026
Add an images plugin which runs txrm2tiff conversion of xrms to annotated tiffs, then makes a jpg thumbnail for display Links to DiamondLightSource/python-murfey#837
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds functionality to read xrm images and request these are converted to tiffs.
Currently this identifies atlas and roi images by finding out if they are montages, and splits them based on pixel size. Better methods may be possible but this should work for now.
Rather than doing the xrm to tiff conversion here it puts a message onto rabbitmq. See DiamondLightSource/cryoem-services#278
Also contains a stub for registering rois in the database.