Conversation
jacob720
left a comment
There was a problem hiding this comment.
This looks good. I was wondering about something similar recently, as my ScrollableImages component takes a prop called backgroundColor. Initially, I named it backgroundColour, but I changed it so it was consistent with the Box prop naming that the prop was ultimately being passed to. What's the best convention to use in this situation?
If it's being passed directly to something else e.g. passing sx props to Box for example, probably best to stick with color. |
ImageColorSchemeSwitch, ImageColorSchemeSwitchType and ImageColorSchemeSwitchProps renamed to ImageColourSchemeSwitch, ImageColourSchemeSwitchType and ImageColourSchemeSwitchProps. User component color prop renamed to colour.
Renamed color to colour in stories.
Closes #78