Skip to content

Rename color to colour#81

Merged
jacob720 merged 1 commit intomainfrom
vbe/color-colour
Jun 27, 2025
Merged

Rename color to colour#81
jacob720 merged 1 commit intomainfrom
vbe/color-colour

Conversation

@VictoriaBeilsten-Edmands
Copy link
Copy Markdown
Collaborator

ImageColorSchemeSwitch, ImageColorSchemeSwitchType and ImageColorSchemeSwitchProps renamed to ImageColourSchemeSwitch, ImageColourSchemeSwitchType and ImageColourSchemeSwitchProps. User component color prop renamed to colour.
Renamed color to colour in stories.

Closes #78

Copy link
Copy Markdown
Contributor

@jacob720 jacob720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I was wondering about something similar recently, as my ScrollableImages component takes a prop called backgroundColor. Initially, I named it backgroundColour, but I changed it so it was consistent with the Box prop naming that the prop was ultimately being passed to. What's the best convention to use in this situation?

@VictoriaBeilsten-Edmands
Copy link
Copy Markdown
Collaborator Author

This looks good. I was wondering about something similar recently, as my ScrollableImages component takes a prop called backgroundColor. Initially, I named it backgroundColour, but I changed it so it was consistent with the Box prop naming that the prop was ultimately being passed to. What's the best convention to use in this situation?

If it's being passed directly to something else e.g. passing sx props to Box for example, probably best to stick with color.

@jacob720 jacob720 merged commit 91b595f into main Jun 27, 2025
1 check passed
@jacob720 jacob720 deleted the vbe/color-colour branch June 27, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ImageColorSchemeSwitch needs to be renamed to ImageColourSchemeSwitch

2 participants