Add base bar component for other components#90
Merged
Conversation
Fix order of slots from screen reader perspective.
akademy
force-pushed
the
jmbw/add-base-bar-component
branch
from
6af4d9c to
8b217a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace multiple implementations of slots, with one single bar component. (To simplfy code and testing). Bar can also stretch across the entire screen if wanted.
Used bar in NavBar, Footer and Breadcrumbs but it can also be used directly for advanced control.
This is quite a large change, so please check everything displays as you would expext it too.
As a consequence:
rootProps, was removed, now styles (etc.) should be passed in directly.Also:
styledfunction, so that styles can no be incorrectly overridden.