Skip to content

Only include relevant files in npm package#92

Merged
jacob720 merged 3 commits intomainfrom
remove-files
Aug 29, 2025
Merged

Only include relevant files in npm package#92
jacob720 merged 3 commits intomainfrom
remove-files

Conversation

@jacob720
Copy link
Copy Markdown
Contributor

Fixes #75
Added a files section to package.json so that only the relevant files are included in the npm package.
Currently I've included /src/ but I'm not sure this is necessary? I could remove this.

@akademy
Copy link
Copy Markdown
Member

akademy commented Aug 6, 2025

Fixes #75 Added a files section to package.json so that only the relevant files are included in the npm package. Currently I've included /src/ but I'm not sure this is necessary? I could remove this.

Could you check whether src/ is necessary? I'm not sure either.

@jacob720
Copy link
Copy Markdown
Contributor Author

I've removed /src, it's not needed.

Copy link
Copy Markdown
Member

@akademy akademy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Package super small now!

@akademy akademy self-requested a review August 26, 2025 11:18
Copy link
Copy Markdown
Member

@akademy akademy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just my one comment about index.js file, and I don't think we need to have the .npmignore file anymore.

Comment thread package.json Outdated
@jacob720 jacob720 requested a review from akademy August 28, 2025 13:07
@jacob720 jacob720 merged commit 0bd0da9 into main Aug 29, 2025
1 check passed
@jacob720 jacob720 deleted the remove-files branch August 29, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Several unnecessary files are being output into the NPM package.

3 participants