Conversation
Collaborator
|
There's a warning It's from having defaultValue and onChange here If it's controlled input you have value and onChange and if it's uncontrolled you have defaultValue but you can only have one or the other. |
Contributor
Author
|
Thanks, I've removed the defaultValue prop, as it should be a controlled input. |
4c4a34f to
28229af
Compare
056c5e3 to
c58eeee
Compare
VictoriaBeilsten-Edmands
approved these changes
Aug 29, 2025
Collaborator
VictoriaBeilsten-Edmands
left a comment
There was a problem hiding this comment.
Looks good. Just a minor point about function def.
VictoriaBeilsten-Edmands
pushed a commit
that referenced
this pull request
Sep 4, 2025
* View multi-page TIFFs in ScrollableImages * Infer if image is tiff from url * Allow .tif extension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've extended the ScrollableImages component so that it can handle multi-image tiffs. It will split the frames into seperate png images which can then be displayed by the browser.