Skip to content

feat: add secrets scanning workflow and pre-commit hooks#145

Merged
vredchenko merged 1 commit intomainfrom
security/add-scanning
Jan 28, 2026
Merged

feat: add secrets scanning workflow and pre-commit hooks#145
vredchenko merged 1 commit intomainfrom
security/add-scanning

Conversation

@vredchenko
Copy link
Collaborator

@vredchenko vredchenko commented Jan 26, 2026

Summary

  • Add leaked-secrets-scan.yml workflow for secrets scanning
  • Scans all pushes to main and all PRs
  • Daily scheduled scan at 3 AM UTC (3-4 AM UK time)
  • Move osv-scanner.toml from webui/ to repo root (consolidate config)
  • Add .pre-commit-config.yaml with detect-secrets hook
  • Add .secrets.baseline (no secrets detected)

Test plan

  • Verify workflow appears as "Leaked Secrets Scan" in Actions tab
  • Verify workflow triggers on PR creation
  • Verify scheduled run at 3 AM UTC
  • Verify pre-commit hooks work: pre-commit install && pre-commit run --all-files

- Add leaked-secrets-scan.yml workflow for daily and PR-based scanning
- Move osv-scanner.toml from webui/ to repo root (consolidate config)
- Add .pre-commit-config.yaml with detect-secrets hook
- Add .secrets.baseline (no secrets detected)
@vredchenko vredchenko added devops CI/CD, deployment, infrastructure, or tooling work security Security fixes, audits, or vulnerability remediation labels Jan 26, 2026
@vredchenko vredchenko marked this pull request as ready for review January 28, 2026 11:05
@vredchenko vredchenko merged commit ed5b3c1 into main Jan 28, 2026
6 checks passed
@vredchenko vredchenko deleted the security/add-scanning branch January 28, 2026 11:59
vredchenko added a commit that referenced this pull request Jan 28, 2026
OSV scanner looks for config files relative to lockfile location
(webui/package-lock.json), not the repo root. Since osv-scanner.toml
was moved to repo root in PR #145, the ignore rules weren't being found.

Add --config flag via scan-args to explicitly point to the config file
at repository root.
vredchenko added a commit that referenced this pull request Jan 28, 2026
Add pre-commit, detect-secrets, and osv-scanner to the prerequisite
checks. These tools were added in PR #145 but the prerequisite check
wasn't updated, so developers aren't warned when they're missing.

All three are marked as optional (required: false) since they're only
needed for security scanning workflows, not core development.
vredchenko added a commit that referenced this pull request Jan 28, 2026
OSV scanner looks for config files relative to lockfile location
(webui/package-lock.json), not the repo root. Since osv-scanner.toml
was moved to repo root in PR #145, the ignore rules weren't being found.

Add --config flag via scan-args to explicitly point to the config file
at repository root.
vredchenko added a commit that referenced this pull request Jan 28, 2026
Add pre-commit, detect-secrets, and osv-scanner to the prerequisite
checks. These tools were added in PR #145 but the prerequisite check
wasn't updated, so developers aren't warned when they're missing.

All three are marked as optional (required: false) since they're only
needed for security scanning workflows, not core development.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops CI/CD, deployment, infrastructure, or tooling work security Security fixes, audits, or vulnerability remediation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant