-
Notifications
You must be signed in to change notification settings - Fork 1
Implement screen validation #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
==========================================
- Coverage 81.83% 81.43% -0.41%
==========================================
Files 7 9 +2
Lines 578 657 +79
==========================================
+ Hits 473 535 +62
- Misses 105 122 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9f93d50 to
da511eb
Compare
|
I attempted adding a custom comment in alongside the "Saved on" comment and it got overwritten/deleted on a subsequent save of the bob screen in phoebus. |
84aa1c5 to
a9bc4b3
Compare
Using comment check, removes any screens that don't need to be validated. Logic to determine whether screen is generated or validated.
4fdf8ce to
dfbf5cf
Compare
dfbf5cf to
c4bf483
Compare
When a file is saved in Phoebus, a comment gets added to the top to say it was saved:
This can be used to determine if a file needs to be validate or completely re-generated.