Skip to content

stop the jsonmap being deleted between build and generate-jsonmap so …#236

Merged
tomkane-dls merged 2 commits into
mainfrom
ci-jsonmap-deletion
Jun 4, 2026
Merged

stop the jsonmap being deleted between build and generate-jsonmap so …#236
tomkane-dls merged 2 commits into
mainfrom
ci-jsonmap-deletion

Conversation

@tomkane-dls
Copy link
Copy Markdown
Collaborator

…that the services CI can pass

For now have added a second hook to services CI to allow both build and generate-jsonmap to run in precommit. This was failing because the jsonmap was deleted after the first hook, and recreated after the second. Overwriting it instead allows the CI to pass checks at both stages

In b01-1-services .pre-commit-config.yaml (here using local techui-builder):

  - repo: local
    hooks:
      - id: tech-ui-build
        name: generate and validate the synoptic and component screens
        language: system
        # only do this if the techui support submodule has been added
        entry: |
          bash -c "
            if [[ -f synoptic/techui-support/techui-support.yaml ]]; then
              techui-builder build synoptic/techui.yaml
            fi"
        files: ^synoptic/
        pass_filenames: false

      - id: tech-ui-jsonmap
        name: generate jsonmap
        language: system
        entry: techui-builder generate-jsonmap synoptic/index.bob
        files: ^synoptic/
        pass_filenames: false

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.25%. Comparing base (f00bae8) to head (0de828b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   96.16%   96.25%   +0.08%     
==========================================
  Files          13       13              
  Lines         966      962       -4     
==========================================
- Hits          929      926       -3     
+ Misses         37       36       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/techui_builder/builder.py Outdated
Copy link
Copy Markdown
Collaborator

@adedamola-sode adedamola-sode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as I think builder and jsonmap operations should now be separated, so builder should not need to delete an old jsonmap file.

@tomkane-dls tomkane-dls merged commit bcf6738 into main Jun 4, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants