add notify skill#343
Conversation
|
Thank you! I rebased the changes on 
|
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
The following two comments are in response to
Is an empty string in the UI okay with you?
| var appName: String | ||
| try { | ||
| val pm: PackageManager = packageManager | ||
| val ai = pm.getApplicationInfo(statusBarNotification.packageName, 0) | ||
| appName = pm.getApplicationLabel(ai).toString() | ||
| } | ||
| catch(e: Exception) { | ||
| e.printStackTrace() | ||
| appName = getString(R.string.appName_error) | ||
| } |
There was a problem hiding this comment.
| var appName: String | |
| try { | |
| val pm: PackageManager = packageManager | |
| val ai = pm.getApplicationInfo(statusBarNotification.packageName, 0) | |
| appName = pm.getApplicationLabel(ai).toString() | |
| } | |
| catch(e: Exception) { | |
| e.printStackTrace() | |
| appName = getString(R.string.appName_error) | |
| } | |
| val appName = try { | |
| val pm: PackageManager = packageManager | |
| val ai = packageManager.getApplicationInfo(statusBarNotification.packageName, 0) | |
| pm.getApplicationLabel(ai).toString() | |
| } catch (e: Exception) { | |
| Log.e(TAG, "Could not get app name", e) | |
| "" | |
| } |
There was a problem hiding this comment.
I made the PR from the master branch
https://github.com/billy-thegreat/dicio-android/blob/new-skill-notify/app/src/main/kotlin/org/stypox/dicio/skills/notify/NotifyHandler.kt
There was a problem hiding this comment.
I changed the Try-catch block in the new-skill-notify branch, setting appName to null, and handling it with a new string in getSpeechOutput() and GraphicalOutput()
There was a problem hiding this comment.
Oh okok, that's cool thanks!
There was a problem hiding this comment.
Please push the code here so I can review the latest version (you just need git checkout master, then git merge new-skill-notify and finally git push).
| var response = "" | ||
| if (notifications.isNotEmpty()) { | ||
| notifications.forEachIndexed { index, notification -> | ||
| val speechPart = ctx.getString(R.string.skill_notify_message, notification.appName, notification.message ?: "") | ||
| response += speechPart | ||
| if (notifications.size > 1 && index < notifications.size - 1) { | ||
| response += ". " | ||
| } | ||
| } | ||
| } | ||
| else { | ||
| response = ctx.getString(R.string.no_notifications) | ||
| } | ||
| return response.trim() |
There was a problem hiding this comment.
| var response = "" | |
| if (notifications.isNotEmpty()) { | |
| notifications.forEachIndexed { index, notification -> | |
| val speechPart = ctx.getString(R.string.skill_notify_message, notification.appName, notification.message ?: "") | |
| response += speechPart | |
| if (notifications.size > 1 && index < notifications.size - 1) { | |
| response += ". " | |
| } | |
| } | |
| } | |
| else { | |
| response = ctx.getString(R.string.no_notifications) | |
| } | |
| return response.trim() | |
| val notificationsStrings = notifications.mapNotNull { notification -> | |
| if (notification.message.isNullOrEmpty()) { | |
| if (notification.appName.isEmpty()) { | |
| null | |
| } else { | |
| ctx.getString(R.string.skill_notify_message_app, notification.appName) | |
| } | |
| } else { | |
| if (notification.appName.isEmpty()) { | |
| ctx.getString(R.string.skill_notify_message_app, notification.message) | |
| } else { | |
| ctx.getString(R.string.skill_notify_message, notification.appName, notification.message) | |
| } | |
| } | |
| } | |
| if (notificationsStrings.isEmpty()) { | |
| return ctx.getString(R.string.no_notifications) | |
| } else { | |
| return notificationsStrings.joinToString(". ") | |
| } |
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Thank you! I made the last polishing steps myself, and I think this is now ready. Here is a screenshot:
2 participants
This pull request adds a new notification skill. Still working on exposing metadata like source (e.g., text message, email) to the user. Future PRs will improve UI by creating distinction between notifications and improving spoken strings and input sentences.