Skip to content

Added Turkish translations for skills#352

Merged
Stypox merged 6 commits into
DicioTeam:masterfrom
Patkek:master
Feb 19, 2026
Merged

Added Turkish translations for skills#352
Stypox merged 6 commits into
DicioTeam:masterfrom
Patkek:master

Conversation

@Patkek
Copy link
Copy Markdown
Contributor

@Patkek Patkek commented Oct 15, 2025

I tried to add Turkish translations. If I have made a mistake, please let me know; I would be happy to correct it.

@Stypox
Copy link
Copy Markdown
Collaborator

Stypox commented Feb 17, 2026

Thank you! Sorry for the very late reply, I was under my exam session. I finally reviewed your sentences, and I noticed a few possible problems (although I don't know Turkish so take everything with a grain of salt):

  • | in this language has operator precedence over everything else, which means that durdur|devre dışı bırak|bitir means ' "durdur dışı bırak" or "devre dışı bırak" or "durdur dışı bitir" or "devre dışı bitir" ' and not ' "durdur" or "devre dışı bırak" or "bitir" ' which is probably what you meant. I tried to correct a few of these mistakes.
  • You seem to have translated many of the sentences literally from English. Feel free to add more or remove ones that are not idiomatic in Turkish! E.g. among the many ways to ask for a joke.
  • I saw that in Turkish some sentences could be written in two directions, e.g. "hesapla 1+1" and "1+1'i hesapla". I think this nuance is missing from various sentences here.
  • I just found out that Turkish uses word suffixes instead of prepositions, e.g. if I understand correctly "from English" would be translated as "İngilizceden". This is not something that the capturing group parser of Dicio supports at the moment. So it will be rather complicated to distinguish between source and target for the translation skill, because "İngilizceden" would be treated as a single word and the "den" wouldn't be

I built an APK with the translations you made included: https://github.com/Stypox/testing-apks/releases/download/27/app-debug.apk
Please test it out, see which sentences do not work as expected, and adapt the current sentences so that they match better. I made a few fixes myself, so please also review if b25c855 makes sense. Thanks again!

@Patkek
Copy link
Copy Markdown
Contributor Author

Patkek commented Feb 17, 2026

Currently I made some tests. Here is what I found:

Weather:

  • On (.where.<da|de|daki|deki>?)? hava (durumu|tahmini|raporu|durumu) (nedir|nasıl|ne gibi)? and hava (durumu|tahmini|raporu|durumu) (nedir|nasıl|ne gibi)? (.where.<da|de|daki|deki>?)? as you said, because of suffixes it does not understand 'locationda hava nasıl' but understands 'location da hava nasıl'
  • Fixed another | problem. (nedir|nasıl|ne gibi)? -> (nedir|nasıl|(ne gibi))?

Navigation:

  • Same as weather, when I say 'beni locationya götür' it treats with 'ya' instead only location. 'beni location ya götür' works as intended (While it's grammatically incorrect).

Telephone:

  • When I say 'person ara' it instead search the internet with person. In Turkish 'ara' is both used for search and dial. I'm not sure which one is most used and what should I do. (They are both used commonly.)

Current Time:

  • 'kaç saat' is not commonly used. Removed.

Translation:

  • Same suffix issue.

On your debug APK, Calculator, timer and joke skills were not available so, I couldn't test them. Made some adjustments also e600288.

@Stypox
Copy link
Copy Markdown
Collaborator

Stypox commented Feb 18, 2026

Thank you for the quick response! I fixed another small thing and here is another APK which includes your commit: https://github.com/Stypox/testing-apks/releases/download/28/app-debug.apk . If you confirm this is ok I think we can merge.

On your debug APK, Calculator, timer and joke skills were not available so, I couldn't test them.

Yeah, for calculator and timer the reason is that the number parser is currently only translated in English and Italian, and translating it requires writing and testing a lot of Kotlin code. For the joke skill, the reason is that the server that we currently use for jokes only supports a handful languages. If you can find a public and free API that provides turkish jokes feel free to make another Pull Request to add support for it! See JokeSkill.kt.

@Patkek
Copy link
Copy Markdown
Contributor Author

Patkek commented Feb 18, 2026

I made some updates. Currently it seems OK for me. I will also check for jokes API later. Thank you for your response!

Copy link
Copy Markdown
Collaborator

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again! I will merge this for now. If needed, feel free to open a new PR to make further improvements :-)

@Stypox Stypox merged commit 7877566 into DicioTeam:master Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants