Added Turkish translations for skills#352
Conversation
|
Thank you! Sorry for the very late reply, I was under my exam session. I finally reviewed your sentences, and I noticed a few possible problems (although I don't know Turkish so take everything with a grain of salt):
I built an APK with the translations you made included: https://github.com/Stypox/testing-apks/releases/download/27/app-debug.apk |
|
Currently I made some tests. Here is what I found: Weather:
Navigation:
Telephone:
Current Time:
Translation:
On your debug APK, Calculator, timer and joke skills were not available so, I couldn't test them. Made some adjustments also e600288. |
|
Thank you for the quick response! I fixed another small thing and here is another APK which includes your commit: https://github.com/Stypox/testing-apks/releases/download/28/app-debug.apk . If you confirm this is ok I think we can merge.
Yeah, for calculator and timer the reason is that the number parser is currently only translated in English and Italian, and translating it requires writing and testing a lot of Kotlin code. For the joke skill, the reason is that the server that we currently use for jokes only supports a handful languages. If you can find a public and free API that provides turkish jokes feel free to make another Pull Request to add support for it! See JokeSkill.kt. |
|
I made some updates. Currently it seems OK for me. I will also check for jokes API later. Thank you for your response! |
Stypox
left a comment
There was a problem hiding this comment.
Thank you again! I will merge this for now. If needed, feel free to open a new PR to make further improvements :-)
I tried to add Turkish translations. If I have made a mistake, please let me know; I would be happy to correct it.