Adds missing spanish .dslf files#76
Merged
Merged
Conversation
Stypox
approved these changes
Apr 28, 2022
Collaborator
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Thank you! Looks good to me.
I contributed to weblate but don't know when/if those contributions will be merged into this repository
Don't worry, I will merge those before releasing
would be glad to take some time to help with the dicio-numbers translation
That would be great, thanks! Note that it requires some Java knowledge.
I don't know if this PR (in case that it gets approval) should wait for those changes before merging.
Nope ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67
I could see, however, that some strings are missing from the spanish translation too, and that dicio-numbers doesn't have a spanish package.
I contributed to weblate but don't know when/if those contributions will be merged into this repository, and would be glad to take some time to help with the dicio-numbers translation.
I don't know if this PR (in case that it gets approval) should wait for those changes before merging.