Skip to content

Conversation

@EdgarScott
Copy link

No description provided.

Sanne and others added 30 commits August 12, 2019 16:54
…nCoordinatorImpl should be lazily initialized
…eThenNativeRead tests are failing on SQL Server
…DateTimeTest failing on Sybase for year 1600
This does not change the behavior of the class at all: it simply
restructures the code to allow for the changes in the next commits.
…ices of individual (non-aggregated) class loaders
Before fix method org.hibernate.internal.util.StringHelper#replace
matched placeholders illegally in case when ordinal parameters list was
expanded. Ex. placeholder ?1 was matched with ?11, ?12, ?13 etc. For
queries with 2 or more IN clauses with different collections there were
a situation when ?1 from the first clause matched with already expanded
placeholders from the second collection. Each match led to recursive
call of replace method. If collection in second clause was very long
then StackOverflowError occurred.

Fix adds check of partial placeholder match for wholeWords mode which
is used in expanding list parameters. Partial matches are skipped
during replace.
…AfterALockExceptionTest.testStatementIsClosed tests fail on Sybase

HHH-13577 : Re-enable LockTest for SybaseASE15Dialect
…se64, from_base64, regexp_replace, regexp_instr, regexp_substr
Sanne and others added 29 commits August 27, 2019 18:25
…yImplementor argument instead of PersisterCreationContext
…yImplementor argument instead of PersisterCreationContext
ConnectorJ 8 is the version used in WildFly integration tests.
ConnectorJ 5 is apparently no longer tested.

Note this solves most timezone-related issues we've been having.
MySQL ConnectorJ 8.x returns the wrong date
when the JVM default timezone is different from the server timezone:
https://bugs.mysql.com/bug.php?id=91112
…TypeTest

We were testing GMT instead of UTC-8 without even knowing it...
…ead' test for MySQL

The returned time is right (otherwise #writeThenRead would fail), it's
just that a different day is returned, but it won't affect the LocalTime
representation manipulated by the user.
…adb task

It's already the version we use when running test -Pdb=mariadb, so let's
be consistent.
…-generation.scripts.action in hibernate.properties
It's already the version we use when running test -Pdb=hana, so let's
be consistent.
@EdgarScott EdgarScott merged commit c007fd4 into add-tests-for-StringHelper Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.