feat: remove Korean page#160
Conversation
DGBNOOB
left a comment
DGBNOOB
left a comment
There was a problem hiding this comment.
Review Summary — Remove Korean Page (61fda55)
Files changed: 5
Thank you for adding the vercel.app preview link — it made it much easier to review the changes. The most visible update is in the language dropdown menu, where the Korean (ko) option has been removed. It previously appeared between ja and zh. Beyond this visual confirmation, I did not perform functional testing; my review focused solely on the file changes.
Files Updated
js/languagerouter.js— Korean route removedko/index.html— deletedlangmenu/desktop.html— Korean entry removedlangmenu/mobile.html— Korean entry removed
I wasn’t entirely sure about the sitemap.xml changes, so I asked Copilot for a summary. This was the explanation:
🧩 Summary of the sitemap.xml Change (PR #160)
The pull request removes the Korean-language page (/ko/) from the DigiByte.org sitemap, aligning with the overall goal of fully removing the Korean page from the website.
🔍 What actually changed
- One deletion: the
<url>entry referencing/ko/was removed. - One addition: the sitemap was updated to reflect the remaining supported languages.
- No other structural changes were made.
🧭 Why this matters
- Search engines will no longer index the Korean page.
- The sitemap remains accurate and avoids SEO issues such as dead links.
- This change is consistent with the removal of
/ko/index.htmland the Korean entries in the language menus andlanguagerouter.js.
I expected this update to be more involved than simply deleting ko/index.html, and that turned out to be true. Dennis, thank you again for handling this. I could have attempted it with AI assistance, but I wouldn’t have been confident that all references were removed cleanly or that search engines would stop indexing the page.
Recommendation: Approve — cACK
|
Are you able to resolve the conflicts @DennisPitallano? |
DennisPitallano
force-pushed
the
master
branch
from
61fda55 to
e411369
Compare
|
new PR #162 |
3 participants
preview: https://dg-bio.vercel.app/
This pull request removes support for the Korean language (
ko) across the website. The changes ensure that Korean is no longer available as a language option in the language menus and is also removed from the sitemap, so it will not appear in search engine alternate language listings.Most important changes:
Language menu updates:
ko) language option from the desktop language menu inlangmenu/desktop.html.ko) language option from the mobile language menu inlangmenu/mobile.html.Routing and sitemap updates:
ko) in the sitemap (sitemap.xml), so search engines will no longer see it as an available alternate language. This includes removing the<xhtml:link rel="alternate" hreflang="ko" ... />entries throughout the file. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22]js/languagerouter.jsto removekofrom the list of supported languages for routing.