Merged
Conversation
JaredTate
added a commit
that referenced
this pull request
Mar 18, 2026
…(Bug #23) The Qt wallet could hang indefinitely on the 'DigiByte is shutting down...' dialog when a DigiDollar time-locked position existed. The GetDDTimeLocks polling loop fired every 60 seconds for 19+ hours without completing shutdown. Root cause: The QTimer in DigiDollarPositionsWidget was created as a local variable in setupUI() and never stopped during shutdown. The timer callback called GetDDTimeLocks() which acquires cs_dd_wallet, potentially deadlocking against the shutdown thread tearing down the wallet. Fix: - Store autoRefreshTimer as member variable (m_autoRefreshTimer) - Stop timer in destructor via stopRefresh() - Stop timer when wallet model is set to null (shutdown teardown path) - Add ShutdownRequested() guard in updatePositions() as safety net - Add null m_walletModel check before any wallet access Qt/wallet layer only — no consensus changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DigiByte specific pow_tests
What is the intention of this PR?
This PR fixes the
pow_testswith DigiByte's specific PoW Implementation.Description of the changes
The commit SmartArray@ae74c4d updated the
pow_testsunit test in order to test DigiBytes Proof Of Work.How to verify?
Expected outcome