Tweak format for fatal logs to include more data#279
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
=======================================
Coverage 97.45% 97.46%
=======================================
Files 24 24
Lines 1219 1221 +2
Branches 235 247 +12
=======================================
+ Hits 1188 1190 +2
Misses 30 30
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects the assignment of message and cause properties in the BootstrapException class and enhances the fatal log formatting to display more detailed error information including the error cause and properly formatted stack traces.
- Fixed the swapped
messageandcauseassignments inBootstrapExceptionconstructor - Enhanced
fatalLogfunction to format errors withErrorName - cause: messagepattern and improved stack trace presentation - Updated test assertions to check
error.causeinstead oferror.messageto match the corrected behavior
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/helpers/errors.mts | Corrected BootstrapException to properly assign message to this.message and cause to this.cause |
| src/helpers/logger.mts | Enhanced fatalLog formatting to include error cause and improved stack trace presentation |
| testing/wiring.spec.mts | Updated test assertions to check error.cause for error codes instead of error.message |
| package.json | Updated dependency versions for various dev and runtime dependencies |
| yarn.lock | Lockfile updates corresponding to package.json dependency version changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📬 Changes
Before
After
🗒️ Checklist
code of conduct