Complete Bubbletea v2 Migration#20
Merged
Merged
Conversation
Upgrade all existing Charm libraries to v2 as well. Followed the migration guide specified at https://github.com/charmbracelet/bubbletea/blob/main/UPGRADE_GUIDE_V2.md.
Contributor
|
@Digital-Shane lgtm, thanks. |
Owner
Author
|
Everything for v2 is merged and tagged :) . Check the update guide mentioned in the change log for more info. If you run into any problems open an issue and I'll take a look. It should be all good though. I tested the changes with my title-tidy app and everything is working on my end. |
|
Thank you for the hard work!!! Really appreciated!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@darkhz @danvergara
I had a couple changes to roll into this to keep main clean, so I had to make a new PR. I kept your commit @darkhz so you'll still get contribute credit. I have a couple more unrelated changes to make, but I should be able to roll out v2 by the end of the day.