feat(task): add new service task_manager#33
Merged
Merged
Conversation
Ekyoz
reviewed
Feb 25, 2026
There was a problem hiding this comment.
(buf.validate.field).required = true,
Il faut indiquer que c'est obligatoire pour les champs necessaires pour les request/response.
Ekyoz
reviewed
Feb 25, 2026
Ekyoz
reviewed
Feb 25, 2026
There was a problem hiding this comment.
_messages au lieu de _message pour le nom du fichier
Ekyoz
reviewed
Feb 25, 2026
| // - cancellation_reason: Reason for cancellation. | ||
| // - error_message: Human-readable error message. | ||
| // - exception_traceback: Full traceback if applicable. | ||
| message TaskError { |
There was a problem hiding this comment.
ajouter la validation avec CEL pour chaque string
(buf.validate.field).required = true,
(buf.validate.field).string.min_len = 1
xaviave
force-pushed
the
feat/task_service
branch
from
9e0b760 to
5a53174
Compare
Ekyoz
reviewed
Feb 25, 2026
Ekyoz
reviewed
Feb 25, 2026
Ekyoz
reviewed
Feb 25, 2026
| // Fields: | ||
| // - success: Whether the operation was successful. | ||
| // - tasks: Tasks with updated status after the stop. | ||
| message StopTasksResponse { |
Ekyoz
reviewed
Feb 25, 2026
| (buf.validate.field).int32.gte = 0 | ||
| ]; | ||
| // tasks is the list of tasks with their current status. | ||
| repeated Task tasks = 2; |
Ekyoz
reviewed
Feb 25, 2026
| // | ||
| // Fields: | ||
| // - tasks: Tasks with their pending signal state. | ||
| message GetSignalsResponse { |
Ekyoz
requested changes
Feb 25, 2026
Ekyoz
left a comment
Ekyoz
left a comment
There was a problem hiding this comment.
Il y a quelque validations manquantes et faut bien ajouter le required = true/false sur tous les champs.
A terme les responses vont changer avec les objets paginations et les bulks.
refactor(zod): split validation-mapper.ts into focused modules Extract validation-mapper.ts (817 lines) into validation/ directory with dedicated modules: types.ts (ValidationChain, MethodTarget), cel-parser.ts (CEL expression → Zod translation), constraint-processors.ts (unified buf.validate processors), and chain.ts (field extraction logic). Eliminate field/item duplication via MethodTarget abstraction. feat(task): simplify Task message and CreateTasksRequest Remove mission_id from CreateTasksRequest, replace last_updated/error fields with heartbeat_at in Task message, renumber fields accordingly. feat(task): update amp feat(task): update amp feat(task): getisgnals as a bulk query
xaviave
force-pushed
the
feat/task_service
branch
from
409f905 to
fa66148
Compare
Relixik
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add new task service allowing tassk management via signal handling, heartbeat and logs.