Skip to content

Adding strategy config and refacto storage strategy#49

Merged
xaviave merged 1 commit intodevfrom
feature/tpe-update-strategies
Apr 2, 2025
Merged

Adding strategy config and refacto storage strategy#49
xaviave merged 1 commit intodevfrom
feature/tpe-update-strategies

Conversation

@thibaud-perrin
Copy link
Copy Markdown
Contributor

@thibaud-perrin thibaud-perrin commented Apr 1, 2025

  • refactor strategies and implement costs
  • reworked the grpc
  • adding service config
  • update storage service examples
  • Updating jobmanager

Close #50

@thibaud-perrin thibaud-perrin added the Enhancement Denotes improvements to existing features rather than new feature development. label Apr 1, 2025
@thibaud-perrin thibaud-perrin self-assigned this Apr 1, 2025
@thibaud-perrin thibaud-perrin requested a review from a team April 1, 2025 13:25
@thibaud-perrin thibaud-perrin added the Ok for Reviews Dev ok, ready for reviews. label Apr 1, 2025
@thibaud-perrin thibaud-perrin marked this pull request as ready for review April 1, 2025 13:41
Comment thread src/digitalkin/modules/_base_module.py Outdated
Comment thread src/digitalkin/modules/_base_module.py
Comment thread src/digitalkin/services/cost/cost_strategy.py
Copy link
Copy Markdown
Contributor

@xaviave xaviave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes

Comment thread examples/start_grpc_server_module.py Outdated
Comment thread src/digitalkin/services/cost/cost_strategy.py
Comment thread src/digitalkin/services/cost/grpc_cost.py Outdated
Comment thread src/digitalkin/modules/_base_module.py Outdated
@thibaud-perrin thibaud-perrin force-pushed the feature/tpe-update-strategies branch 2 times, most recently from a98d1cf to 84166a6 Compare April 1, 2025 15:33
Comment thread examples/modules/text_transform_module.py
Copy link
Copy Markdown
Contributor

@GuillaumeSachet GuillaumeSachet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread src/digitalkin/services/cost/cost_strategy.py
feature(storage): reworked the queries
feat(services): adding service config
feature(storage): update storage sevice
fix(storage): fix examples and some reviews comments
@thibaud-perrin thibaud-perrin force-pushed the feature/tpe-update-strategies branch from c171292 to 51e473b Compare April 2, 2025 09:56
@xaviave xaviave merged commit b25cce9 into dev Apr 2, 2025
4 checks passed
@thibaud-perrin thibaud-perrin deleted the feature/tpe-update-strategies branch April 3, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Denotes improvements to existing features rather than new feature development. Ok for Reviews Dev ok, ready for reviews.

Projects

None yet

3 participants