Skip to content

🎎 Connect WF with Front#10

Merged
Linzell merged 7 commits into
devfrom
CCO-connect-WF
Jun 28, 2024
Merged

🎎 Connect WF with Front#10
Linzell merged 7 commits into
devfrom
CCO-connect-WF

Conversation

@Linzell
Copy link
Copy Markdown
Contributor

@Linzell Linzell commented Jun 25, 2024

No description provided.

The code changes update the message name from `GetWorkflowRequest` to `ReadKinWorkflowRequest` in the `kin_workflow.proto` file. This change aligns with the naming convention for consistency and clarity.
@Linzell Linzell self-assigned this Jun 25, 2024
@Linzell Linzell added ⚠️ high priority Need to work in priority ! 💓 enhancement New feature or request 🚠 infrastructure Change the infrastructure for the project labels Jun 25, 2024
@Linzell Linzell requested a review from a team June 25, 2024 10:17
Linzell added 5 commits June 27, 2024 13:37
The code changes add the import statement for `google/protobuf/any.proto` in the `kin_workflow.proto` file. This import is necessary to use the `google.protobuf.Any` type in the `Node` message's `data` field, allowing for more flexible data storage.
The code changes add the `Target` and `Source` messages to the `kin_workflow.proto` file. These messages define the structure for the `targets` and `sources` fields in the `DataNode` message, allowing for more detailed information about the connections between nodes in the workflow.
The code changes introduce new RPC endpoints and message fields to the `kin_workflow.proto` file. This includes the addition of the `AddNodeWorkflow`, `AddEdgeWorkflow`, `UpdateNodePositionWorkflow`, `DeleteNodeWorkflow`, and `DeleteEdgeWorkflow` RPCs, along with their corresponding request and response messages. These changes enhance the functionality and flexibility of the KinWorkflowService API.
@Linzell Linzell marked this pull request as ready for review June 28, 2024 09:41
@Linzell Linzell added the 🚀 ok for Reviews Dev ok, ready for reviews label Jun 28, 2024
Copy link
Copy Markdown
Contributor

@thibaud-perrin thibaud-perrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

The code changes add the `CreateKinWorkflow` RPC to the `KinWorkflowService` in the `kin_workflow.proto` file. This RPC allows creating a new Kin workflow by sending a `CreateKinWorkflowRequest` with the `kinId` parameter. This enhancement improves the functionality of the KinWorkflowService API.
@Linzell Linzell merged commit 7ae8450 into dev Jun 28, 2024
@Linzell Linzell deleted the CCO-connect-WF branch June 28, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💓 enhancement New feature or request ⚠️ high priority Need to work in priority ! 🚠 infrastructure Change the infrastructure for the project 🚀 ok for Reviews Dev ok, ready for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants