Require the number of passed tests to match up.#17
Merged
WalterBright merged 1 commit intoDigitalMars:masterfrom Dec 9, 2017
Merged
Require the number of passed tests to match up.#17WalterBright merged 1 commit intoDigitalMars:masterfrom
WalterBright merged 1 commit intoDigitalMars:masterfrom
Conversation
s-ludwig
force-pushed
the
test_passing_cases
branch
5 times, most recently
from
ea242a2 to
215e03b
Compare
This forces the number of passed tests to stay constant by default. For changes that actually aim to fix failing test cases, the expected number needs to be updated accordingly. The goal is to detect any unintended logic changes, no matter if the result is positive or negative.
s-ludwig
force-pushed
the
test_passing_cases
branch
from
215e03b to
e939764
Compare
Contributor
Author
|
Green now! |
Contributor
Author
|
@WalterBright do you have any objections? Would be good to get this merged, so that #15 and #16 can be rebased on top of this to have an official test result. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This forces the number of passed tests to stay constant by default. For changes that actually aim to fix failing test cases, the expected number needs to be updated accordingly. The goal is to detect any unintended logic changes, no matter if the result is positive or negative.