Fix testsuite#26
Merged
WalterBright merged 4 commits intoDigitalMars:masterfrom Dec 3, 2021
Merged
Conversation
Contributor
Author
|
@WalterBright Can you enable GitHub actions under Settings->Actions? Adding a branch protection rule for master to require the "Test262" job (which will only appear after it has been run at least once) to pass would also be good. I hope to get #16 up to date and merged, as well as fixing some warnings after the test suite is active again. edit: Looks like actions may already be enabled and just need to be confirmed to run for the PR. |
s-ludwig
force-pushed
the
fix_testsuite
branch
2 times, most recently
from
85ac370 to
371d6df
Compare
…n tests. Since DMDScripts implements an old version of the ECMA standard, newer tests are currently mostly irrelevant for now. However, since we fail a lot of tests, it is important to have a known baseline in terms of which tests succeed. For now, this is only counting the number of passed tests as opposed to tracking each test case individually.
Crashes on Linux/LDC, probably due to an issue with the varargs implementation. Removing, since this isn't used anyway.
s-ludwig
force-pushed
the
fix_testsuite
branch
from
371d6df to
e608602
Compare
Contributor
|
"Allow all actions" is already checked on. |
Contributor
|
What else do I need to do? Just merge this? |
Contributor
Author
|
Note really sure, TBH, I'll see what happens with the other PR once it gets rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test suite has been broken for a long time and I decided to give this another go. It now pins the test suite to a certain commit, so that the test cases that are run are fixed and the test suite itself doesn't use feature that are not supported by DMDScript.
This also switches to GitHub actions.