Conversation
Wrap each validation site in a retry loop that shows the error via show_input_popup and re-prompts instead of aborting the entire TUI flow. Default to Cv25519 when no cipher is selected, matching the existing default behavior for validity duration.
Replace '..', '/' and '\' with '_' in the user ID before using it as a filename component in generate_keypair. This prevents a crafted User ID containing '../' from writing files outside ~/.pgpman/. (Issue #36)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate_keypairnow sanitizes../,/, and\in User IDs before constructing file paths, preventing writes outside~/.pgpman/Closes #36