Skip to content

Add support for push constants to SPIRVShaderResources #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TheMostDiligent merged 20 commits into from
Dec 13, 2025
Merged

Add support for push constants to SPIRVShaderResources #733

TheMostDiligent merged 20 commits into from
Dec 13, 2025

Conversation

@hzqst
Copy link
Contributor

@hzqst hzqst commented Dec 12, 2025 •
edited
Loading

  • Add support for push constants to SPIRVShaderResources
  • Add tests that will compile a simple shader with each resource type, create SPIRVShaderResources from byte code and test that the expected resource is properly reflected.

hzqst added 3 commits December 12, 2025 13:47
@hzqst
Add SPIRVShaderResourcesTest
b9512bc
@hzqst
Fixed an issue that diligent_spirv_cross::SPIRType::BaseType::Struct …
b9c461a 
…recognized as RESOURCE_DIM_UNDEFINED

Fixed an issue that UniformTexelBuffer error out when DumpResources.
@hzqst
fix formatting
743e7f2
TheMostDiligent
TheMostDiligent requested changes Dec 12, 2025
View reviewed changes
TheMostDiligent
TheMostDiligent reviewed Dec 12, 2025
View reviewed changes
TheMostDiligent
TheMostDiligent requested changes Dec 12, 2025
View reviewed changes
@TheMostDiligent TheMostDiligent merged commit e1571f2 into DiligentGraphics:inline_constants Dec 13, 2025
37 checks passed
@TheMostDiligent TheMostDiligent changed the title Vk Push Constanst update based on #729 Add support for push constants to SPIRVShaderResources Dec 13, 2025
TheMostDiligent pushed a commit that referenced this pull request Dec 13, 2025
@hzqst @TheMostDiligent
SPIRVShaderResources: Add support for push constants (#733)
eac2632
@TheMostDiligent TheMostDiligent mentioned this pull request Dec 13, 2025
Open
@hzqst hzqst deleted the inline_constants2 branch December 13, 2025 05:50
TheMostDiligent pushed a commit that referenced this pull request Dec 13, 2025
@hzqst @TheMostDiligent
SPIRVShaderResources: Add support for push constants (#733)
cd07435
TheMostDiligent pushed a commit that referenced this pull request Dec 16, 2025
@hzqst @TheMostDiligent
SPIRVShaderResources: Add support for push constants (#733)
5434a10
TheMostDiligent pushed a commit that referenced this pull request Dec 23, 2025
@hzqst @TheMostDiligent
SPIRVShaderResources: Add support for push constants (#733)
03c05e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheMostDiligent TheMostDiligent Awaiting requested review from TheMostDiligent TheMostDiligent is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hzqst @TheMostDiligent