Skip to content

fix: relation service #10138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guanbinrui merged 2 commits into from
Jul 21, 2023
Merged

fix: relation service #10138

guanbinrui merged 2 commits into from
Jul 21, 2023

Conversation

@lelenei
Copy link
Contributor

@lelenei lelenei commented Jul 21, 2023

Description

Closes # mf-4573

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@lelenei lelenei added this to the 2.21.3 milestone Jul 21, 2023
guanbinrui
guanbinrui reviewed Jul 21, 2023
View reviewed changes
@lelenei lelenei marked this pull request as ready for review July 21, 2023 05:27
@guanbinrui guanbinrui merged commit 65a7eae into hotfix/2.21.3 Jul 21, 2023
@guanbinrui guanbinrui deleted the lelenei/mf-4573 branch July 21, 2023 05:34
guanbinrui added a commit that referenced this pull request Jul 22, 2023
@guanbinrui @lelenei @UncleBill
[Release] Hotfix 2.21.2 => 2.21.3 (patch) (#9933)
9cb401b 
* chore: bump version 2.21.3

* refactor: wc v1 bridge url (#9934)

* refactor: update bridge url

* refactor: deactive remote flags

* refactor: enable remote config

* fix: sentry tx reports (#10062)

* chore: add logs

* refactor: update comment

* chore: remove dev guard

* Revert "chore: remove dev guard"

This reverts commit 89eb425.

* Revert "chore: add logs"

This reverts commit d29021e.

* fix: all tx should be recorded

* fix: relation service query (#10096)

* fix: mf-4561 click on shadowdom cause ui jumping (#10114)

* fix: mf-4448 some nft have been filtered out (#10112)

* fixup! fix: mf-4561 click on shadowdom cause ui jumping (#10114) (#10125)

* fix: relation service (#10138)

* fix: relation service

* refactor: reply review

* fix: twitter api (#10139)

* fix: relation service (#10141)

---------

Co-authored-by: lelenei <72531217+lelenei@users.noreply.github.com>
Co-authored-by: UncleBill <billbill290@gmail.com>
guanbinrui pushed a commit that referenced this pull request Jul 22, 2023
@lelenei @guanbinrui
fix: relation service (#10138)
9e6d55e 
* fix: relation service

* refactor: reply review
guanbinrui added a commit that referenced this pull request Jul 22, 2023
@guanbinrui @lelenei @UncleBill
chore: pick 2.21.3 (#10143)
f88aeec 
* fix: relation service query (#10096)

* fixup! fix: mf-4561 click on shadowdom cause ui jumping (#10114) (#10125)

* fix: relation service (#10138)

* fix: relation service

* refactor: reply review

* fix: relation service (#10141)

* chore: update lock file

---------

Co-authored-by: lelenei <72531217+lelenei@users.noreply.github.com>
Co-authored-by: UncleBill <billbill290@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guanbinrui guanbinrui guanbinrui left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.21.3

Development

Successfully merging this pull request may close these issues.

3 participants

@lelenei @guanbinrui