Skip to content

fix: change twitter logo #10189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guanbinrui merged 1 commit into from
Jul 27, 2023
Merged

fix: change twitter logo #10189

guanbinrui merged 1 commit into from
Jul 27, 2023

Conversation

@lelenei
Copy link
Contributor

@lelenei lelenei commented Jul 27, 2023

Description

Closes #mf-4665

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@lelenei lelenei added this to the 2.21.4 milestone Jul 27, 2023
@guanbinrui guanbinrui merged commit f4fab75 into hotfix/2.21.4 Jul 27, 2023
@guanbinrui guanbinrui deleted the lelenei/mf-4665 branch July 27, 2023 16:48
guanbinrui added a commit that referenced this pull request Jul 28, 2023
@guanbinrui @lelenei
[Release] Hotfix 2.21.3 => 2.21.4 (patch) (#10162)
2a027e4 
* chore: bump version 2.21.4

* chore: patches/@walletconnect__socket-transport (#10165)

* chore: patches/@walletconnect__socket-transport

* chore: update lock file

* chore: resume Connector

* chore: resumeConnector

* refactor: improve wc connection (#10168)

* refactor: improve wc connection

* refactor: destroy connection

* refactor: disable v2

* chore: debug

* refactor: remove connector

* chore: patch wc

* refactor: improve stability

* refactor: improve connection debugger

* fix: lint errors

* feat: switch logo plugin (#10178)

* feat: switch logo plugin

* chore: update lock file

* feat: plugin storage

* fix: bugfix

* refactor: code style

* fix: switch logo plugin (#10184)

* refactor: code stlye

* refactor: code stlye

* fix: async

* feat: application settings dialog

* fix: use legacy settings

* fix: typo

* fix: type errors

---------

Co-authored-by: lelenei <zwpsky@gmail.com>

* fix: logo color (#10186)

* fix: change twitter logo (#10189)

* fix: copywriting (#10187)

* fix: adjust ui (#10190)

* fix: show switch logo in guidestep (#10191)

* fix: icon border (#10193)

* fix: copywriting (#10197)

* fix: open switch logo (#10201)

* fix: add new line to share text (#10203)

---------

Co-authored-by: lelenei <zwpsky@gmail.com>
Co-authored-by: lelenei <72531217+lelenei@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guanbinrui guanbinrui guanbinrui approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.21.4

Development

Successfully merging this pull request may close these issues.

3 participants

@lelenei @guanbinrui