feat: mf-6735 integrate privy wallet support #12281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
swkatmask
force-pushed
the
feat/mf-6735-privy-wallet
branch
10 times, most recently
from
f5aba3f to
487f75e
Compare
swkatmask
force-pushed
the
feat/mf-6735-privy-wallet
branch
2 times, most recently
from
865a83e to
a2ba668
Compare
guanbinrui
reviewed
Oct 10, 2025
There was a problem hiding this comment.
Pull Request Overview
This pull request integrates Privy wallet support into the Mask Network extension, enabling users to create and manage wallets through X (Twitter) authentication. The implementation adds comprehensive Privy provider integration, updates UI components for wallet creation, and handles transaction signing through Privy wallets.
Key changes:
- Added Privy provider and API integration for wallet management with OAuth flow
- Integrated Privy wallet support in MaskWalletProvider and various UI components
- Updated transaction request handling to support Privy wallet signing
- Modified UI components to include Privy wallet creation options alongside traditional methods
Reviewed Changes
Copilot reviewed 75 out of 77 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web3-providers/src/Privy/ | New Privy API client and type definitions for wallet integration |
| packages/web3-providers/src/Web3/EVM/providers/MaskWallet.ts | Updated to include Privy wallets in wallet enumeration |
| packages/web3-hooks/base/src/usePrivyWallet.ts | New hook for managing Privy wallet instances |
| packages/mask/popups/pages/Wallet/components/ImportCreateWallet/ | Updated UI to include Privy wallet creation option |
| packages/mask/popups/pages/Wallet/Interaction/ | Modified transaction and signing requests to handle Privy wallets |
| packages/shared-base/src/Privy/ | Privy provider setup and chain configurations |
| packages/mask/background/services/helper/oauth-x.ts | OAuth 1.0a implementation for X authentication |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/mask/popups/pages/Wallet/components/ImportCreateWallet/index.tsx
Outdated
Show resolved
Hide resolved
swkatmask
force-pushed
the
feat/mf-6735-privy-wallet
branch
from
d45787d to
0405de4
Compare
Jack-Works
reviewed
Oct 10, 2025
Jack-Works
reviewed
Oct 10, 2025
packages/mask/content-script/utils/shadow-root/ContentScriptGlobalProvider.tsx
Show resolved
Hide resolved
Jack-Works
reviewed
Oct 10, 2025
swkatmask
force-pushed
the
feat/mf-6735-privy-wallet
branch
3 times, most recently
from
6dc9b9c to
cc1152b
Compare
Jack-Works
reviewed
Oct 11, 2025
packages/mask/content-script/utils/shadow-root/ContentScriptGlobalProvider.tsx
Show resolved
Hide resolved
swkatmask
commented
Oct 11, 2025
packages/mask/content-script/utils/shadow-root/ShadowRootAttachPointRoot.tsx
Show resolved
Hide resolved
swkatmask
force-pushed
the
feat/mf-6735-privy-wallet
branch
from
a39da49 to
3623775
Compare
Jack-Works
reviewed
Oct 15, 2025
swkatmask
force-pushed
the
feat/mf-6735-privy-wallet
branch
from
5ba15d6 to
792abd9
Compare
swkatmask
force-pushed
the
feat/mf-6735-privy-wallet
branch
2 times, most recently
from
fecbba7 to
037e661
Compare
guanbinrui
reviewed
Oct 21, 2025
packages/mask/popups/pages/Wallet/Interaction/WalletSignRequest.tsx
Outdated
Show resolved
Hide resolved
guanbinrui
reviewed
Oct 21, 2025
packages/mask/popups/pages/Wallet/Interaction/TransactionRequest.tsx
Outdated
Show resolved
Hide resolved
…and update popup UI
- add Privy provider and API integration for wallet management - support Privy wallets in MaskWalletProvider and wallet hooks - enable login and wallet creation via X (Twitter) account with auth timeout handling - adapt transaction requests to handle Privy wallet signing - update cspell dictionaries and ignore reg exps for privy related domains - adjust UI components for importing/creating wallets with Privy option
wrap application root providers and modals with PrivySetupProvider and mount PrivySetup where needed.
swkatmask
force-pushed
the
feat/mf-6735-privy-wallet
branch
from
07798ab to
051a31d
Compare
swkatmask
force-pushed
the
feat/mf-6735-privy-wallet
branch
from
ee5f153 to
2431603
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mask.atlassian.net/browse/mf-6735