Merged
Conversation
hanszhoou
commented
Mar 7, 2023
| if (isNativeTokenAddress(address) || !isValidAddress(address)) return undefined | ||
| const data = await fetchFromChainbase<FT_Price>( | ||
| urlcat('/v1/token/price', { chain_id: chainId, contract_address: address }), | ||
| urlcat('/v1/token/price', { chain_id: ChainId.Mainnet, contract_address: address }), |
Contributor
Author
There was a problem hiding this comment.
solana token price is from coingeko, chainbase is evm only.
Member
There was a problem hiding this comment.
I don't think it's correct. The address could be from other EVM chains that don't exist on Mainnet and fail the API.
hanszhoou
changed the title
Deploying with
|
| Latest commit: |
b6dc236
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c5da8c53.maskbook.pages.dev |
| Branch Preview URL: | https://sentry-report-chainbase-pric.maskbook.pages.dev |
guanbinrui
approved these changes
Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://mask.atlassian.net/browse/MF-3609
Closes # (NO_ISSUE)
Type of change
Previews
Checklist
console.logsIf this PR depends on external APIs:
chrome-extension://[id]moz-extension://[id]