feat(api): extend structured error handling to all error responses#20
Merged
guanbinrui merged 1 commit intomasterfrom Feb 28, 2026
Merged
Conversation
Add error_type and HTTP status codes to remaining API error cases: - Invalid input errors (invalid_input, Http400) - No results errors (no_results, Http200) - Import HttpCode and Http200 in router_utils for template usage
9c5efe5 to
060105d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends the structured error handling introduced in #19 to cover all remaining API error cases.
Changes
error_typestatus.niminvalid_inputsearch.niminvalid_inputsearch.niminvalid_inputsearch.nimno_resultssearch.niminvalid_inputtimeline.nimno_resultsDesign Decisions
invalid_input+ Http400: Used for all client input validation errorsno_results+ Http200: Used for valid searches that return empty results (semantic success)Test plan
error_typefield