Merge upstream zedeus/nitter master into master#22
Merged
Conversation
Co-authored-by: yav <796176@protonmail.com>
Fixes zedeus#1352 Fixes zedeus#553 Fixes zedeus#249
Fixes zedeus#727 Fixes zedeus#1023
* Update actions and switch to GitHub runners * Bump workflow Python version to 3.14 * Reuse nitter build for integration test * Add missing libpcre3 installation to workflow * Consolidate workflow runtime deps install * Make nitter binary executable * Run nimble md and scss simultaneously in workflow * Run tests with 4 workers in workflow * Rerun failing integration tests * Bump integration test workers to 5 * Improve python dep install and run less workers * Use native GitHub Actions Redis service * Lower integration test workers to 2 * Switch to poetry to cache venv * Ensure poetry is installed before setup-python * Fix poetry sync command * Switch back to 3 workers * Cache poetry install * WIP * WIP * Fix poetry/pipx caching * Speed up integration test significantly * WIP * Cleanup
Merges 40 upstream commits adding broadcasts, account info, mixed-media support, configurable retry logic, community notes, edit history, preference URL params, and various bug fixes. Compatibility fixes for our JSON API layer: - Updated src/jsons/timeline.nim to use new MediaEntities model (tweet.media replacing tweet.gif/video/photos) - Replaced deprecated cookiePrefs() with requestPrefs() in JSON routes - Preserved enableJsonApi config field alongside new granular RSS flags - Preserved JSON API router registrations in nitter.nim Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
guanbinrui
force-pushed
the
sync/upstream-zedeus
branch
from
b4c0104 to
1ff123d
Compare
…24) Fixes four issues introduced or exposed by the upstream zedeus merge: 1. **Media field breaking change** — replaced split `photos`/`videos`/`gifs` fields with a unified `media` array. Each element carries a `type` discriminator ("photo"/"video"/"gif") so consumers don't need to infer kind from field presence. Video variants serialize `contentType` as the MIME string (not ordinal). This matches the intent of the `main` branch (`b4c0104`) and aligns with the upstream `MediaEntities` model. 2. **New upstream tweet fields** — added `history` (edit IDs), `note` (community note text), `isAd`, `isAI`, and `stats.views` to `formatTweetAsJson` so callers can act on upstream data. 3. **Unused `prefs` variable in search.nim** — removed the dead `prefs = requestPrefs()` binding that was never referenced after the `cookiePrefs()` → `requestPrefs()` fix in the merge. 4. **CORS support** — re-applied from `feat/cors-support` (f9c6ff8) which was never merged into master. Added `corsOrigin()` template and CORS response headers to all `respJson*` helpers, updated the health endpoint, and added an `options re"/api/.*"` preflight handler in `nitter.nim`. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Delete run-tests.yml entirely and remove the tests job + needs dependency from build-docker.yml so Docker builds no longer gate on the test suite. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
masterinto this forkenableJsonApi,/api/*routes)differui/nitterimage tags, ARM64 build job)Upstream highlights
Test plan
run-tests.ymland Docker workflow)mediafield shapeenableRSS*config flagsMade with Cursor